Skip to content

Add missing h_neglect#1562

Closed
NoraLoose wants to merge 1 commit into
mom-ocean:mainfrom
NoraLoose:fix-h_neglect
Closed

Add missing h_neglect#1562
NoraLoose wants to merge 1 commit into
mom-ocean:mainfrom
NoraLoose:fix-h_neglect

Conversation

@NoraLoose
Copy link
Copy Markdown
Contributor

Looks like the addition of h_neglect is missing in one line for the computation of zonal isopycnal slopes.

Note that is is correctly added in the meridional counterpart:

hg2A = h(i,j,k-1)*h(i,j+1,k-1) + h_neglect2
hg2B = h(i,j,k)*h(i,j+1,k) + h_neglect2
hg2L = h(i,j,k-1)*h(i,j,k) + h_neglect2
hg2R = h(i,j+1,k-1)*h(i,j+1,k) + h_neglect2
haA = 0.5*(h(i,j,k-1) + h(i,j+1,k-1)) + h_neglect
haB = 0.5*(h(i,j,k) + h(i,j+1,k)) + h_neglect
haL = 0.5*(h(i,j,k-1) + h(i,j,k)) + h_neglect
haR = 0.5*(h(i,j+1,k-1) + h(i,j+1,k)) + h_neglect

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2022

Codecov Report

Merging #1562 (507bdb9) into main (399a7db) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage   28.94%   28.94%           
=======================================
  Files         242      242           
  Lines       71591    71591           
=======================================
  Hits        20723    20723           
  Misses      50868    50868           
Impacted Files Coverage Δ
src/core/MOM_isopycnal_slopes.F90 44.93% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@marshallward
Copy link
Copy Markdown
Collaborator

Hi Nora, could you re-send this to the NOAA-GFDL/MOM6 repository for review? Thanks

https://github.com/noaa-gfdl/mom6

@NoraLoose
Copy link
Copy Markdown
Contributor Author

I re-send it here: NOAA-GFDL#98. I'm closing this.

@NoraLoose NoraLoose closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants