Add missing h_neglect#1562
Closed
NoraLoose wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
Coverage 28.94% 28.94%
=======================================
Files 242 242
Lines 71591 71591
=======================================
Hits 20723 20723
Misses 50868 50868
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Collaborator
|
Hi Nora, could you re-send this to the NOAA-GFDL/MOM6 repository for review? Thanks |
Contributor
Author
|
I re-send it here: NOAA-GFDL#98. I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the addition of
h_neglectis missing in one line for the computation of zonal isopycnal slopes.Note that is is correctly added in the meridional counterpart:
MOM6/src/core/MOM_isopycnal_slopes.F90
Lines 363 to 370 in 399a7db