Disable clock sync of in-loop BML timers#1542
Closed
marshallward wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1542 +/- ##
=========================================
Coverage 29.15% 29.15%
=========================================
Files 239 239
Lines 71467 71467
=========================================
+ Hits 20837 20838 +1
+ Misses 50630 50629 -1
Continue to review full report at Codecov.
|
This patch overrides the default clock sync (configured in FMS) for the CPU clocks inside of the bulk mixed layer's loops. This prevents model hangs due to an inconsistent number of clock syncs when different ranks have different size domains.
marshallward
force-pushed
the
bml_clocks
branch
from
af40daa to
c43022a
Compare
Hallberg-NOAA
approved these changes
Nov 10, 2021
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This PR adroitly alleviates the anomalies addressed in Issue #1527, which can be annulled after this advance is accepted. A-1 accomplishment, @marshallward.
Collaborator
Author
|
Amazing alliteration, @Hallberg-NOAA 🤣 |
This was referenced Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch overrides the default clock sync (configured in FMS) for the
CPU clocks inside of the bulk mixed layer's loops.
This prevents model hangs due to an inconsistent number of clock syncs
when different ranks have different size domains.