EMC stochastic candidate 20211028#1538
Conversation
update with NOAA-EMC fork
update my fork
Update ocn_stoch branch with dev/emc
update with EMC's fork
remove conflict with dev/emc
further resolve conflict
merge dev/emc into ocean stochastic branch
put id_sppt_wts, etc back.
Merge with EMC fork
alperaltuntas
left a comment
alperaltuntas
left a comment
There was a problem hiding this comment.
NCAR tests are passing.
add comments to stochastic physics stub
|
Phil just added the comments for the arguments in the two subroutines |
|
are there any further comments/modification requirement for this PR ? |
|
@jiandewang I think we are OK on GFDL's end. I am doing some final tests against dev/gfdl and will finalize soon (hopefully tomorrow). |
|
Everyone who has approved: could you also use the GitHub "approve" button? Merges now require four approvals. (Ping: @abozec @kshedstrom ) |
|
I'm not seeing an approve button: |
|
@kshedstrom If you click on the files changed tab, there is a review changes dropdown list on the top right, under that there is an approve button. |
|
Since we have the approvals in writing, I am going to merge this one myself, overriding the new 4-reviewer protocol. There are still a few small questions around permissions and how to best secure the codebase, and it's getting too close to the holidays to wait for them to be resolved, and there's no reason for this PR to wait on those problems to be solved. @pjpegion and @jiandewang Thanks very much for your patience and working through the issues raised by the other contributors. |
|
I will squash-merge this one, due to the large number of commits. |
|
@marshallward thank you very much to have the first PR done in the new MOM6 repository. |
PR mom-ocean#1538 merge to dev/gfdl
10 participants
The stochastic physics feature has been added in MOM6. The following are from Phil Pegion:
The ocean stochastic physics has been re-coded such that there is a wrapper in config_src/external/OCEAN_stochastic_phyiscs that contains the calls to the external stochastic_physics repository. This has been added to support non-UFS applications of MOM6 where the stochastic_physics repository is not part of the build. The init and run procedures are called from src/core/MOM.F90. I have also created a new control structure stochastic_CS, which contains the logical variables, and random patterns which are then passed into src/parameterizations/vertical/MOM_diabadic_driver.F90 and src/parameterizations/vertical/MOM_energetic-PBL.F90.
The writing of the ocean stochastic restarts sit in config_src/nuopc_cap/mom_cap.F90