cpu_clock_id: synchro_flag arg changed to logical#1535
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1535 +/- ##
=========================================
Coverage 29.10% 29.10%
=========================================
Files 239 239
Lines 71524 71526 +2
=========================================
+ Hits 20818 20820 +2
Misses 50706 50706
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Oct 25, 2021
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree with the sense of these changes, although in the comment describing the new "sync" argument, "An flag" should be "A flag".
This patch modifies the `cpu_clock_id` interface so that the `synchro_flag` argument is converted into a platform-agnostic logical flag. The current implementation requires the synchronization flag to be defined using FMS norms (zero-bit) and also would force users to follow FMS predefined flags for other values. This patch changes the sync flag to a logical, and modifies the default flag to enable synced clocks (based on `clock_flag_default`). `synchro_flag` is also renamed to `sync` for simplicity.
marshallward
force-pushed
the
sync_clock_flag
branch
from
573ce72 to
c053fdc
Compare
Collaborator
|
This PR passed the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13921. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch modifies the
cpu_clock_idinterface so that thesynchro_flagargument is converted into a platform-agnostic logicalflag.
The current implementation requires the synchronization flag to be
defined using FMS norms (zero-bit) and also would force users to follow
FMS predefined flags for other values.
This patch changes the sync flag to a logical, and modifies the default
flag to enable synced clocks (based on
clock_flag_default).synchro_flagis also renamed tosyncfor simplicity.