+Optional just_read_params args are now mandatory#1524
Merged
marshallward merged 2 commits intoOct 20, 2021
Conversation
Made 44 previously optional just_read_params arguments into mandatory arguments and renamed them just_read to avoid duplicated variables. This change should be minimally disruptive, as these optional arguments were always being provided. Some argument documentation blocks were also reformatted or the comments in them were corrected. All answers are bitwise identical, but some arguments have changed.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1524 +/- ##
=========================================
Coverage 29.07% 29.08%
=========================================
Files 239 239
Lines 71655 71611 -44
=========================================
- Hits 20836 20830 -6
+ Misses 50819 50781 -38
Continue to review full report at Codecov.
|
Collaborator
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13857 ✔️ |
marshallward
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made 44 previously optional just_read_params arguments into mandatory
arguments and renamed them just_read to avoid duplicated variables. This change
should be minimally disruptive, as these optional arguments were always being
provided. Some argument documentation blocks were also reformatted or the
comments in them were corrected. All answers are bitwise identical, but some
arguments have changed.