Always create single-threaded files in 1 PE runs#1521
Merged
marshallward merged 2 commits intoOct 25, 2021
Conversation
Modified create_file to always specify that the threading will be for a single PE to do the writing to a single file if there is only a single ocean PE, to avoid some incorrect behavior inside of the FMS IO modules. This can fix restart problems in some single-processor cases with an inconsistent setting of the optional threading argument, but in all cases that ran correctly before, all answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1521 +/- ##
=========================================
Coverage 29.09% 29.09%
=========================================
Files 239 239
Lines 71567 71568 +1
=========================================
+ Hits 20824 20825 +1
Misses 50743 50743
Continue to review full report at Codecov.
|
marshallward
approved these changes
Oct 25, 2021
Collaborator
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
I think this is a reasonable change which will help protect against potential threading definition inconsistencies.
Collaborator
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13913 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified create_file to always specify that the threading will be for a single
PE to do the writing to a single file if there is only a single ocean PE, to
avoid some incorrect behavior inside of the FMS IO modules. This can fix
restart problems in some single-processor cases with an inconsistent setting of
the optional threading argument, but in all cases that ran correctly before, all
answers are bitwise identical.