Refactored solo_driver/MOM_driver.F90#1520
Merged
marshallward merged 2 commits intoOct 15, 2021
Merged
Conversation
Refactored solo_driver/MOM_driver.F90 to move logically self-contained blocks of code into separate subroutines within this file to improve the readability of the code and to reduce the number of global variables. This started out as an exercise to explore the use of the F2008 block / end block construct to reduce the scope of variables, but the code ended up being cleaner just using traditional subroutines contained in this file. All answers are bitwise identical and all output files are unaltered.
adcroft
reviewed
Oct 13, 2021
Collaborator
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Much cleaner! Will leave it to @marshallward to approve too
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1520 +/- ##
=========================================
Coverage 29.06% 29.07%
=========================================
Files 239 239
Lines 71691 71699 +8
=========================================
+ Hits 20840 20845 +5
- Misses 50851 50854 +3
Continue to review full report at Codecov.
|
marshallward
approved these changes
Oct 15, 2021
Collaborator
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
I also like the new function separation.
Collaborator
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13813 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored solo_driver/MOM_driver.F90 to move logically self-contained blocks
of code into separate subroutines within this file to improve the readability of
the code and to reduce the number of global variables. This started out as an
exercise to explore the use of the F2008 block / end block construct to reduce
the scope of variables, but the code ended up being cleaner just using
traditional subroutines contained in this file. All answers are bitwise
identical and all output files are unaltered.