Correct logical associated with NW2 tracers#1518
Merged
marshallward merged 1 commit intoOct 13, 2021
Merged
Conversation
Collaborator
adcroft
commented
Oct 12, 2021
adcroft
commented
- @klindsay28 spotted two issues for the NW2 tracers
- Use of the wrong logical variable
- Incorrect comment
- Using the wrong logical meant that the ideal age pacakge was being called in addition to the NW2 package, but did not affect the NW2 tracers themselves.
- @klindsay28 spotted two issues for the NW2 tracers 1. Use of the wrong logical variable 2. Incorrect comment - Using the wrong logical meant that the ideal age pacakge was being called in addition to the NW2 package, but did not affect the NW2 tracers themselves.
Codecov Report
@@ Coverage Diff @@
## dev-gfdl-main-candidate-2021-10-04 #1518 +/- ##
===================================================================
Coverage 29.06% 29.06%
===================================================================
Files 237 237
Lines 71643 71643
===================================================================
Hits 20823 20823
Misses 50820 50820
Continue to review full report at Codecov.
|
Collaborator
|
I agree that these changes are correct and should be merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.