fix low mode in tidal_mixing#1515
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1515 +/- ##
=========================================
Coverage 29.08% 29.08%
=========================================
Files 239 239
Lines 71586 71582 -4
=========================================
Hits 20821 20821
+ Misses 50765 50761 -4
Continue to review full report at Codecov.
|
|
Hi @raphaeldussin , given the increased PR traffic, would it be possible to move these draft PRs to another place, such as your own repo or the Discussions tab, until they are ready for review? |
|
After some discussion, I agree with @raphaeldussin that draft PRs fill a niche for discussing potential code changes and encouraging new contributions, and that it's far too premature to simply stop using them. We might explore other options in the future (tags, Discussion tab, etc) but that can wait for now. |
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes all seem reasonable, especially given that the internal tides ray tracing code is a (maturing) work-in progress. This PR should be accepted once it has passed the pipeline testing.
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13888 ✔️ |
this PR updates some function prototypes to pass the necessary structures for the get_lowmode function to work.
The teleport function is commented out since its behavior is inadequate and might not be necessary anymore.