Fix to sponge verbosity, also some documentation.#1500
Merged
Conversation
This is required for the u,v sponges to be invariant of tiling. I don't know why, but the problem only showed up for me in a narrow channel in the Bering domain.
The MOM_control_struct is declared and passed as a pointer to a CS (usually allocated anonymously) and treated as if it were a pointer, even though there is currently no real advantage to doing so. After the FMS update, the deallocation of this CS was causing a segmentation fault in the PGI compilers. While the underlying cause was never determined, it is likely due to some automated deallocation of the CS contents, whose addressing became scrambled. This problem can be resolved by moving all of the CS contents to stack, so that the contents are automatically removed upon exiting whatever function it was instantiated. Subsequent calls can reference the local (or parent) stack contents.
- Without this change, the edges don't reproduce on restart due to the h values outside being nonsense.
- Also updated frazil ice documentation.
…-30' into dev/esmg
- where is the water depth negative?
- Also, added a link to OBC wiki page. - Working around bibtex hashing issue I don't understand, renaming some unused tags. - Making MOM_barotropic when the water depth goes negative.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1500 +/- ##
============================================
- Coverage 29.04% 29.02% -0.03%
============================================
Files 237 237
Lines 71626 71779 +153
============================================
+ Hits 20807 20831 +24
- Misses 50819 50948 +129
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Sep 24, 2021
Collaborator
There was a problem hiding this comment.
I agree with all the code changes in this PR, and I have read through the documentation changes, and believe them to be substantially correct as well. This PR has passed the TC testing, and the pipeline testing has run successfully at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13648 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a chat with @Hallberg-NOAA and @adcroft, we decided to clean up some excessive print statements from MOM6's sponge code. Here it is. Also, some added verbosity to a warning about negative water depths. Thirdly, the last of the internal vertical diffusion documentation (for now).