Fix diags internal waves#1487
Merged
marshallward merged 3 commits intoSep 1, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1487 +/- ##
============================================
- Coverage 29.04% 29.04% -0.01%
============================================
Files 236 236
Lines 71398 71401 +3
============================================
Hits 20736 20736
- Misses 50662 50665 +3
Continue to review full report at Codecov.
|
raphaeldussin
force-pushed
the
fix_diags_intwaves
branch
from
faaf6c7 to
a253d37
Compare
Hallberg-NOAA
approved these changes
Aug 31, 2021
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes seem correct to me, and I think that this can be merged after it has been updated to be based on the latest version of dev/gfdl and passes the TC and pipeline testing.
Collaborator
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13515 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diags previously not working using
DIAG_AS_CHKSUMbecause of axes definition and/or unitialized values