(*)Use depths in DOME and dye tracer initialization#1482
Merged
marshallward merged 2 commits intoAug 30, 2021
Conversation
Initialize the horizontal stripes of tracers in the DOME and dye examples based on the depth from the (flat) sea surface rather than the height above the seafloor. These are mathematically equivalent, but there could be small changes in the tracer distributions. Because these changes only impact passive tracers, all of the physical solutions are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1482 +/- ##
=========================================
Coverage 29.13% 29.14%
=========================================
Files 235 235
Lines 71077 71081 +4
=========================================
+ Hits 20711 20713 +2
- Misses 50366 50368 +2
Continue to review full report at Codecov.
|
Collaborator
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13479 ✔️ |
marshallward
approved these changes
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize the horizontal stripes of tracers in the DOME and dye examples
based on the depth from the (flat) sea surface rather than the height above the
seafloor. These are mathematically equivalent, but there could be small changes
in the tracer distributions. Because these changes only impact passive tracers,
all of the physical solutions are bitwise identical.