Testing: Replace bc with awk; framework support#1471
Merged
Hallberg-NOAA merged 2 commits intoAug 27, 2021
Conversation
This patch adds three minor updates to the build and test systems: 1. A framework selection bug was fixed. The variable name was missing a $ token. 2. the FRAMEWORK variable was added to .testing/Makefile to facilitate testing of both FMS frameworks. 3. Restart half-periods no longer use `bc` to compute the duration in seconds; we now use awk, which is more commonly available.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1471 +/- ##
=========================================
Coverage 29.13% 29.13%
=========================================
Files 235 235
Lines 71061 71061
=========================================
Hits 20707 20707
Misses 50354 50354 Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Aug 27, 2021
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This PR looks entirely plausible to me, and it has passed both the automated TC testing and the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13464.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds three minor updates to the build and test systems:
A framework selection bug was fixed. The variable name was missing a
$ token.
the FRAMEWORK variable was added to .testing/Makefile to facilitate
testing of both FMS frameworks.
Restart half-periods no longer use
bcto compute the duration inseconds; we now use awk, which is more commonly available.