Fix to commit 893a06e062 which broke the SIGMA_SHELF_ZSTAR option#1459
Merged
marshallward merged 2 commits intoAug 6, 2021
Conversation
- Testing with an ice shelf (e.g. ISOMIP) and using
the SIGMA_SHELF_ZSTAR coordinate would have caught this bug.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1459 +/- ##
=========================================
Coverage 29.30% 29.30%
=========================================
Files 234 234
Lines 70600 70600
=========================================
Hits 20686 20686
Misses 49914 49914
Continue to review full report at Codecov.
|
Collaborator
marshallward
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the SIGMA_SHELF_ZSTAR coordinate would have caught this bug.