Flag inconsistent parameters if ADIABATIC = True#1438
Merged
Conversation
Add checks for inconsistent parameter settings in adiabatic_driver_init() when ADIABATIC = True, and issue instructive error messages if any are found. This PR addresses MOM6 issue mom-ocean#1417. All answers are bitwise identical, although some cases where the inconsistent parameter settings were previously ignored may now issue fatal errors and will not run.
adcroft
approved these changes
Jul 28, 2021
Collaborator
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
These changes make sense. Testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checks for inconsistent parameter settings in adiabatic_driver_init() when
ADIABATIC = True, and issue instructive error messages if any are found. This
PR addresses MOM6 issue #1417. All answers are bitwise identical, although some
cases where the inconsistent parameter settings were previously ignored may now
issue fatal errors and will not run.