(*)Correct multi-name handling by save_restart#1426
Merged
marshallward merged 2 commits intoJun 21, 2021
Conversation
Corrected the code that adds a suffix to the restart file names created by save_restart when there are multiple restart files to satisfy the NetCDF requirement that all variables in a time record start within the first 4 Gb of the record in the case where the restart file name was provided with the ".nc" extension already included. The code that reads the restarts already handled this case properly, but save_restart had an extra ".nc" in the names. MOM6 usually provided the root for the restart file without the .nc extension, but SIS2 does not and was having trouble reading its own restart files in some very large (e.g., 1/12-degree global) cases; identical corrections were made separately to MOM_restart.F90 and SIS_restart.F90. All answers and filenames are bitwise identical in any cases that were correctly restarting before.
|
It works now. Thanks! |
Collaborator
marshallward
approved these changes
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the code that adds a suffix to the restart file names created by
save_restart when there are multiple restart files to satisfy the NetCDF
requirement that all variables in a time record start within the first 4 Gb of
the record in the case where the restart file name was provided with the ".nc"
extension already included. The code that reads the restarts already handled
this case properly, but save_restart had an extra ".nc" in the names. MOM6
usually provided the root for the restart file without the .nc extension, but
SIS2 does not and was having trouble reading its own restart files in some very
large (e.g., 1/12-degree global) cases; identical corrections were made
separately to MOM_restart.F90 and SIS_restart.F90. All answers and filenames
are bitwise identical in any cases that were correctly restarting before.