Ice dynamics#1416
Merged
Merged
Conversation
…ts spatial variability. A subroutine initialize_ice_C_basal_friction() is added to initialize this parameter either with a constant value or reading from a file.
… from a constant to a field to allow for its spatial variability; several parameters are added to a restart file. In MOM_ice_shelf_initialize.F90 a subroutine initialize_ice_AGlen is added; it initializes the ice-stiffness parameter A_Glen either by reading it from a file or assigning a constant value.
Hallberg-NOAA
approved these changes
Jun 17, 2021
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes make sense to me, and appear to me to be properly implemented based on my visual inspection. Moreover, this PR has passed both the TC testing and the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12878.
Although this PR could change the documentation of some parameters in the parameter_doc files for some cases, it does not change the parameter_doc files in the MOM6-examples test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes have been made to MOM_ice_shelf_dynamics.F90 and MOM_ice_shelf_initialize.F90:
The ice-stiffness parameter (A_GLEN_ISOTHERM) used to compute ice viscosity and the basal friction parameter (BASAL_FRICTION_COEFF) used to compute basal traction have been changed from constants to 2D fields to allow for their spatial variability.
Subroutines
initialize_ice_C_basal_friction()andinitialize_ice_AGlen()to initialize these fields either with constant values or by reading them from files were added to MOM_ice_shelf_initialize.F90.Several fields have been added to a restart file.
A test case for initialization of both fields from a file is /lustre/f2/dev/gfdl/Olga.Sergienko/MOM6expls/ocean_only/ice_shelf_solo/IS2Dincl_plane_betaAGlen_file_sym
A test case for initialization of both fields with constant values is /lustre/f2/dev/gfdl/Olga.Sergienko/MOM6expls/ocean_only/ice_shelf_solo/IS2Dincl_plane_betaAGlen_const_sym
A test case for non-symmetric memory is /lustre/f2/dev/gfdl/Olga.Sergienko/MOM6expls/ocean_only/ice_shelf_solo/IS2Dincl_plane_betaAGlen_const_nsym