Remove duplicated solvers between regrid modules#1408
Merged
Hallberg-NOAA merged 2 commits intoMay 27, 2021
Conversation
In the removal of regrid_edge_slopes, a couple of the solvers became duplicated between regrid_edge_values and regrid_solvers. Here, they're simply made consistent by removing the solvers from regrid_edge_values, and bringing over the zero-pivot check for the linear solver that was in one variation but not the other.
Hallberg-NOAA
approved these changes
May 27, 2021
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have examined these changes, and I have carefully compared the routines that are being removed with the alternate versions that are being called. I agree that this PR is both correct and a useful simplification.
Collaborator
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12764. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the removal of
regrid_edge_slopes(dc1bed6), a couple of the solvers became duplicated betweenregrid_edge_valuesandregrid_solvers. Here, they're simply made consistent by removing the solvers fromregrid_edge_values, and bringing over the zero-pivot check for the linear solver that was in one variation but not the other.