Skip to content

Trying to fix Kelvin wave boundary condition. #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marshallward merged 2 commits into from
May 26, 2021
Merged

Trying to fix Kelvin wave boundary condition. #1406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5106dd2
Trying to fix Kelvin wave boundary condition.
kshedstrom May 21, 2021
6dd824f
Merge branch 'dev/gfdl' into dev/esmg
Hallberg-NOAA May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/user/Kelvin_initialization.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,15 +209,10 @@ subroutine Kelvin_set_OBC_data(OBC, CS, G, GV, US, h, Time)
omega = 2.0 * PI / (12.42 * 3600.0) ! M2 Tide period
val1 = US%m_to_Z * sin(omega * time_sec)
else
N0 = US%L_to_m*US%s_to_T * sqrt((CS%rho_range / CS%rho_0) * GV%g_Earth * (US%m_to_Z * CS%H0))
N0 = US%L_to_m*US%s_to_T * sqrt((CS%rho_range / CS%rho_0) * (GV%g_Earth / CS%H0))
lambda = PI * CS%mode * CS%F_0 / (CS%H0 * N0)
! Two wavelengths in domain
plx = 4.0 * PI / G%len_lon
pmz = PI * CS%mode / CS%H0
lambda = pmz * CS%F_0 / N0
omega = CS%F_0 * plx / lambda

! lambda = PI * CS%mode * CS%F_0 / (CS%H0 * N0)
! omega = (4.0 * CS%H0 * N0) / (CS%mode * G%len_lon)
omega = (4.0 * CS%H0 * N0) / (CS%mode * G%len_lon)
endif

sina = sin(CS%coast_angle)
Expand Down Expand Up @@ -261,7 +256,7 @@ subroutine Kelvin_set_OBC_data(OBC, CS, G, GV, US, h, Time)
enddo
endif
else
! Not rotated yet
! Baroclinic, not rotated yet
segment%eta(I,j) = 0.0
segment%normal_vel_bt(I,j) = 0.0
if (segment%nudged) then
Expand Down