Skip to content

Remove ppoly_t data type. Implment Openmp#14

Merged
adcroft merged 3 commits into
dev/masterfrom
user/z1l/remove_ppoly
Apr 28, 2014
Merged

Remove ppoly_t data type. Implment Openmp#14
adcroft merged 3 commits into
dev/masterfrom
user/z1l/remove_ppoly

Conversation

@Zhi-Liang
Copy link
Copy Markdown
Contributor

@Zhi-Liang Zhi-Liang commented Apr 22, 2014

Remove pply_t data type. This is necessary for OpenMP implementation. Implement OpenMP.

@adcroft adcroft self-assigned this Apr 25, 2014
@adcroft
Copy link
Copy Markdown
Collaborator

adcroft commented Apr 25, 2014

I'm getting segmentation violations for the sloshing test case using a dynamic executable. I'm stuck in the review talks at the moment so can't look into it until Monday. Do you want to see if you can run the three sloshing tests?

@Zhi-Liang
Copy link
Copy Markdown
Contributor Author

Zhi-Liang commented Apr 25, 2014

Hi Alistair,

I will run the slosh test.

Zhi

On Fri, Apr 25, 2014 at 1:51 PM, Alistair Adcroft (GFDL) <
notifications@github.com> wrote:

I'm getting segmentation violations for the sloshing test case using a
dynamic executable. I'm stuck in the review talks at the moment so can't
look into it until Monday. Do you want to see if you can run the three
sloshing tests?

Reply to this email directly or view it on GitHubhttps://github.com//pull/14#issuecomment-41420661
.

@Zhi-Liang
Copy link
Copy Markdown
Contributor Author

Zhi-Liang commented Apr 25, 2014

Hi Alistair,

I fixed a bug in MOM_regridding.F90 by initialize degree_i to be 4. All
three sloshing tests run OK with -O0 and -O2 when compiling with -openmp.
I pushed the fix in user/z1l/remove_ppoly.

Thanks,

Zhi

On Fri, Apr 25, 2014 at 1:51 PM, Alistair Adcroft (GFDL) <
notifications@github.com> wrote:

I'm getting segmentation violations for the sloshing test case using a
dynamic executable. I'm stuck in the review talks at the moment so can't
look into it until Monday. Do you want to see if you can run the three
sloshing tests?

Reply to this email directly or view it on GitHubhttps://github.com//pull/14#issuecomment-41420661
.

@adcroft adcroft merged commit 37aba61 into dev/master Apr 28, 2014
@adcroft adcroft deleted the user/z1l/remove_ppoly branch July 29, 2016 18:42
gustavo-marques pushed a commit to gustavo-marques/MOM6 that referenced this pull request Jul 26, 2017
@alperaltuntas
Merge pull request mom-ocean#14 from gustavo-marques/docs
b403edd 
Clean the module and start doxygenizing it
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this pull request Oct 9, 2017
@adcroft
SIS2: Merge pull request mom-ocean#14 from CommerceGov/user/aja/diag_…
4a04a8a 
…bugfix

Bugfix: uo,vo diagnostics were registered on B grid
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this pull request Oct 9, 2017
@adcroft
MOM6: Merge pull request mom-ocean#578 from NCAR/dev/ncar
8b801de 
- NOAA-GFDL/MOM6@ae22a0f Merge pull request mom-ocean#578 from NCAR/dev/ncar
- NOAA-GFDL/MOM6@f4f882f Merge pull request mom-ocean#23 from gustavo-marques/combine_mct_modules
- NOAA-GFDL/MOM6@a85b728 Merge MCT modules
- NOAA-GFDL/MOM6@ba5b5ba Merge pull request mom-ocean#22 from gustavo-marques/check_fluxes
- NOAA-GFDL/MOM6@f5a8483 Adds option to write restart files
- NOAA-GFDL/MOM6@8745b4b Fills additional IOB fluxes
- NOAA-GFDL/MOM6@f6b22ff Merge branch 'dev/ncar' into check_fluxes
- NOAA-GFDL/MOM6@369d5d6 Merge pull request mom-ocean#21 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@2582e0a Adds run paramaters to control SW decomposition
- NOAA-GFDL/MOM6@58f78b9 Fill IOB, some fluxes still need to be checked
- NOAA-GFDL/MOM6@06a30ab Fixed clock and timing
- NOAA-GFDL/MOM6@1bca79b Merge pull request mom-ocean#20 from gustavo-marques/fix_merge
- NOAA-GFDL/MOM6@fb89b08 Adds code that got lost during merge
- NOAA-GFDL/MOM6@7480492 Merge pull request mom-ocean#19 from gustavo-marques/new_merge
- NOAA-GFDL/MOM6@be1e6cf Merge branch 'dev/master' into dev/ncar
- NOAA-GFDL/MOM6@76565cb Merge pull request mom-ocean#17 from gustavo-marques/fix_ssh_slopes
- NOAA-GFDL/MOM6@c04f081 Fix ssh slope calculation
- NOAA-GFDL/MOM6@17d4586 Merge pull request mom-ocean#16 from adcroft/ncar-cherry-picked-fixes
- NOAA-GFDL/MOM6@be46fee (*)Fixes gprime(1) when no layer coordinates are set
- NOAA-GFDL/MOM6@fccb7ae Avoids a SEGV when OBC are not in use with bi-harmonic friction
- NOAA-GFDL/MOM6@f42c970 Merge pull request mom-ocean#15 from gustavo-marques/small_fixes
- NOAA-GFDL/MOM6@31787c2 Adds reference to set_time that was lost during a conflict handling
- NOAA-GFDL/MOM6@d77936e Fix intent(inout) in ice_ocean_boundary
- NOAA-GFDL/MOM6@b403edd Merge pull request mom-ocean#14 from gustavo-marques/docs
- NOAA-GFDL/MOM6@4d346ca Merge branch 'dev/ncar' into docs
- NOAA-GFDL/MOM6@f7c26a5 Clean the module and start doxygenizing it
- NOAA-GFDL/MOM6@cd58e2a Merge pull request mom-ocean#13 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@37a53bc reorganize file structure
- NOAA-GFDL/MOM6@e6c5ddd Merge pull request mom-ocean#12 from gustavo-marques/fill_ice_ocean_bnd
- NOAA-GFDL/MOM6@6b6289a Remove trailing whitespace
- NOAA-GFDL/MOM6@7ce40e5 Fix undefined reference to fill_ice_ocean_bnd
- NOAA-GFDL/MOM6@d517719 Merge branch 'dev/ncar' into fill_ice_ocean_bnd
- NOAA-GFDL/MOM6@b69ab33 Filling ice_ocean_bnd - Draft
- NOAA-GFDL/MOM6@a306c90 Merge pull request mom-ocean#11 from adcroft/use-ocn-public-for-surface
- NOAA-GFDL/MOM6@c83e238 Correct indexing when using ocean_public_type
- NOAA-GFDL/MOM6@1f39c84 Replaces use of "surface" with "ocean_public_type"
- NOAA-GFDL/MOM6@5cd8d7a Filling ice_ocean_bnd, still needs work
- NOAA-GFDL/MOM6@3ceef26 Merge pull request mom-ocean#10 from adcroft/sketch-out-mct-run
- NOAA-GFDL/MOM6@714e8d6 Adds placeholders for stepping foward MOM
- NOAA-GFDL/MOM6@7f2207c Merge pull request #7 from adcroft/fix-mct-whitespace
- NOAA-GFDL/MOM6@a1db77f Cleans up white space
- NOAA-GFDL/MOM6@5700d67 Merge pull request #6 from adcroft/add-use-only-for-imports
- NOAA-GFDL/MOM6@beac3ed Adds "only" for all use statements
- NOAA-GFDL/MOM6@231d19e Merge pull request #5 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@3a923a2 Got initialization working
- NOAA-GFDL/MOM6@8b38141 Wrapped global data
- NOAA-GFDL/MOM6@970f848 added debugging
- NOAA-GFDL/MOM6@2540ed8 Filled empty subroutines in ocn_comp_mct.F90
- NOAA-GFDL/MOM6@ed3ed30 Added ocn_import_export module
- NOAA-GFDL/MOM6@aba7dc2 Completed ocn_init_mct
- NOAA-GFDL/MOM6@5df3bc3 Added method to point ponters to members of ocean_state_type
- NOAA-GFDL/MOM6@57e6086 Added methods to return domain/grid shape
- NOAA-GFDL/MOM6@37e7356 Added ocn_import_export.F90
- NOAA-GFDL/MOM6@2b794da Merge pull request #4 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@fbd405b Added coupler indices module
- NOAA-GFDL/MOM6@fa86163 Merge pull request #3 from NCAR/dev/gfdl
- NOAA-GFDL/MOM6@e8f2999 Merge pull request #2 from gustavo-marques/temp_salt_z_init_file
- NOAA-GFDL/MOM6@86936ba Adds option to read initial temp and salt from separate files
- NOAA-GFDL/MOM6@54f7976 Most initialization working
- NOAA-GFDL/MOM6@426357c Time and calendar initialization in ocn_comp_mct.F90
- NOAA-GFDL/MOM6@346097d Moved blank ocn_comp_mct.F90
- NOAA-GFDL/MOM6@405fecb Merge pull request #1 from gustavo-marques/ice_shelf
- NOAA-GFDL/MOM6@711a613 Removes frazil's contribution to evaporation
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this pull request Oct 9, 2017
@adcroft
MOM6: Merge branch 'dev/master' into dev/gfdl
3f17d14 
- Updates MOM_parameter_doc files.

- NOAA-GFDL/MOM6@cde6d3f Merge branch 'dev/master' into dev/gfdl
- NOAA-GFDL/MOM6@ae22a0f Merge pull request mom-ocean#578 from NCAR/dev/ncar
- NOAA-GFDL/MOM6@f4f882f Merge pull request mom-ocean#23 from gustavo-marques/combine_mct_modules
- NOAA-GFDL/MOM6@a85b728 Merge MCT modules
- NOAA-GFDL/MOM6@ba5b5ba Merge pull request mom-ocean#22 from gustavo-marques/check_fluxes
- NOAA-GFDL/MOM6@f5a8483 Adds option to write restart files
- NOAA-GFDL/MOM6@8745b4b Fills additional IOB fluxes
- NOAA-GFDL/MOM6@f6b22ff Merge branch 'dev/ncar' into check_fluxes
- NOAA-GFDL/MOM6@369d5d6 Merge pull request mom-ocean#21 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@2582e0a Adds run paramaters to control SW decomposition
- NOAA-GFDL/MOM6@58f78b9 Fill IOB, some fluxes still need to be checked
- NOAA-GFDL/MOM6@06a30ab Fixed clock and timing
- NOAA-GFDL/MOM6@1bca79b Merge pull request mom-ocean#20 from gustavo-marques/fix_merge
- NOAA-GFDL/MOM6@fb89b08 Adds code that got lost during merge
- NOAA-GFDL/MOM6@7480492 Merge pull request mom-ocean#19 from gustavo-marques/new_merge
- NOAA-GFDL/MOM6@be1e6cf Merge branch 'dev/master' into dev/ncar
- NOAA-GFDL/MOM6@76565cb Merge pull request mom-ocean#17 from gustavo-marques/fix_ssh_slopes
- NOAA-GFDL/MOM6@c04f081 Fix ssh slope calculation
- NOAA-GFDL/MOM6@17d4586 Merge pull request mom-ocean#16 from adcroft/ncar-cherry-picked-fixes
- NOAA-GFDL/MOM6@be46fee (*)Fixes gprime(1) when no layer coordinates are set
- NOAA-GFDL/MOM6@fccb7ae Avoids a SEGV when OBC are not in use with bi-harmonic friction
- NOAA-GFDL/MOM6@f42c970 Merge pull request mom-ocean#15 from gustavo-marques/small_fixes
- NOAA-GFDL/MOM6@31787c2 Adds reference to set_time that was lost during a conflict handling
- NOAA-GFDL/MOM6@d77936e Fix intent(inout) in ice_ocean_boundary
- NOAA-GFDL/MOM6@b403edd Merge pull request mom-ocean#14 from gustavo-marques/docs
- NOAA-GFDL/MOM6@4d346ca Merge branch 'dev/ncar' into docs
- NOAA-GFDL/MOM6@f7c26a5 Clean the module and start doxygenizing it
- NOAA-GFDL/MOM6@cd58e2a Merge pull request mom-ocean#13 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@37a53bc reorganize file structure
- NOAA-GFDL/MOM6@e6c5ddd Merge pull request mom-ocean#12 from gustavo-marques/fill_ice_ocean_bnd
- NOAA-GFDL/MOM6@6b6289a Remove trailing whitespace
- NOAA-GFDL/MOM6@7ce40e5 Fix undefined reference to fill_ice_ocean_bnd
- NOAA-GFDL/MOM6@d517719 Merge branch 'dev/ncar' into fill_ice_ocean_bnd
- NOAA-GFDL/MOM6@b69ab33 Filling ice_ocean_bnd - Draft
- NOAA-GFDL/MOM6@a306c90 Merge pull request mom-ocean#11 from adcroft/use-ocn-public-for-surface
- NOAA-GFDL/MOM6@c83e238 Correct indexing when using ocean_public_type
- NOAA-GFDL/MOM6@1f39c84 Replaces use of "surface" with "ocean_public_type"
- NOAA-GFDL/MOM6@5cd8d7a Filling ice_ocean_bnd, still needs work
- NOAA-GFDL/MOM6@3ceef26 Merge pull request mom-ocean#10 from adcroft/sketch-out-mct-run
- NOAA-GFDL/MOM6@714e8d6 Adds placeholders for stepping foward MOM
- NOAA-GFDL/MOM6@7f2207c Merge pull request #7 from adcroft/fix-mct-whitespace
- NOAA-GFDL/MOM6@a1db77f Cleans up white space
- NOAA-GFDL/MOM6@5700d67 Merge pull request #6 from adcroft/add-use-only-for-imports
- NOAA-GFDL/MOM6@beac3ed Adds "only" for all use statements
- NOAA-GFDL/MOM6@231d19e Merge pull request #5 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@3a923a2 Got initialization working
- NOAA-GFDL/MOM6@8b38141 Wrapped global data
- NOAA-GFDL/MOM6@970f848 added debugging
- NOAA-GFDL/MOM6@2540ed8 Filled empty subroutines in ocn_comp_mct.F90
- NOAA-GFDL/MOM6@ed3ed30 Added ocn_import_export module
- NOAA-GFDL/MOM6@aba7dc2 Completed ocn_init_mct
- NOAA-GFDL/MOM6@5df3bc3 Added method to point ponters to members of ocean_state_type
- NOAA-GFDL/MOM6@57e6086 Added methods to return domain/grid shape
- NOAA-GFDL/MOM6@37e7356 Added ocn_import_export.F90
- NOAA-GFDL/MOM6@2b794da Merge pull request #4 from alperaltuntas/dev/ncar
- NOAA-GFDL/MOM6@fbd405b Added coupler indices module
- NOAA-GFDL/MOM6@fa86163 Merge pull request #3 from NCAR/dev/gfdl
- NOAA-GFDL/MOM6@e8f2999 Merge pull request #2 from gustavo-marques/temp_salt_z_init_file
- NOAA-GFDL/MOM6@86936ba Adds option to read initial temp and salt from separate files
- NOAA-GFDL/MOM6@54f7976 Most initialization working
- NOAA-GFDL/MOM6@426357c Time and calendar initialization in ocn_comp_mct.F90
- NOAA-GFDL/MOM6@346097d Moved blank ocn_comp_mct.F90
- NOAA-GFDL/MOM6@405fecb Merge pull request #1 from gustavo-marques/ice_shelf
- NOAA-GFDL/MOM6@711a613 Removes frazil's contribution to evaporation
SMoorthi-emc pushed a commit to SMoorthi-emc/MOM6 that referenced this pull request Apr 16, 2020
@jiandewang
Merge pull request mom-ocean#14 from jiandewang/update-to-GFDL-20200108
161cbb9 
Update to gfdl 20200108 dev/master commit
MJHarrison-GFDL referenced this pull request in MJHarrison-GFDL/MOM6 Jun 15, 2021
@Hallberg-NOAA
Merge pull request #14 from CommerceGov/user/aja/diag_bugfix
d4252ef 
Bugfix: uo,vo diagnostics were registered on B grid
gustavo-marques pushed a commit to gustavo-marques/MOM6 that referenced this pull request May 6, 2022
@jskenigson
Merge pull request mom-ocean#14 from jskenigson/stoch_eos_ncar_fix_diag
810efe3 
Don't register stanley diagnostics if scheme is off
jiandewang pushed a commit that referenced this pull request Mar 2, 2026
@DusanJovic-NOAA
Address reviewer comments (#14)
bf7f604 
In mom_cap.F90 rename module variable 'mype' to 'localPet'
Rename mom_ufs_trace_wrapper module to mom_cap_profiling
Add docstrings
gustavo-marques pushed a commit to gustavo-marques/MOM6 that referenced this pull request Apr 14, 2026
@alperaltuntas @jiandewang
@DusanJovic-NOAA @DeniseWorthen @marshallward @mathomp4
Merge main 260408 (mom-ocean#417)
258d4e9 
* Fix divide by zero fpe in apply_oda_incupd (mom-ocean#164)

Move computation of tmp_h inside the if G%mask2dT test to avoid divide by zero error

* Add mom_cap_outputlog.F90 that enables output logging diagnostics at a given hourly output frequency

Author: Denise Worthen
This feature is required for UFS operational configurations and is used to determine when 
MOM6 output (diagnostics and restart) have been completed. The log files created by 
this feature can be queried by the Global Workflow to either trigger downstream jobs 
or to ensure that if a run fails and a restart is required, model output is available 
consistent with a given restart file.

* Adds the ability to read a CDEPS configuration file to provide in-line forcing. 

* Adds the ability to read a CDEPS configuration file to provide in-line forcing. 
Currently this is set up to read a non-climatological lrunoff data stream only.

* Add tracing instrumentation to nuopc driver  (mom-ocean#162)

* adds calls to ufs tracing routines that will create a trace file which can then be visualized, 
  which is found to be useful in identifying various performance issues.

* Update CVMix to Apache-2.0 based release

This patch updates the CVMix submodule to a more recent version that is
licensed under the Apache 2.0 license.  There are no code changes to
CVMix relative to the current version.

* Relicense code to Apache License, Version 2.0

This PR re-licenses the MOM6 source code from the Lesser GNU Public
License, version 3 to Apache License, Version 2.0.  This is done with
the consent of all contributors to the source code.

All source files are now tagged with the following disclaimer.
```
This file is part of MOM6, the Modular Ocean Model version 6.
See the LICENSE file for licensing information.
SPDX-License-Identifier: Apache-2.0
```
All relevent source code, scripts, and macros are now explicitly
identified as part of MOM6.  Configuration files containing scripts,
such as GitHub Actions, have also been tagged.  Any other
configurations, such as model inputs, have been excluded.

* Address reviewer comments (mom-ocean#14)

In mom_cap.F90 rename module variable 'mype' to 'localPet'
Rename mom_ufs_trace_wrapper module to mom_cap_profiling
Add docstrings

* address reviewers comments (mom-ocean#15)

* indenting for mom_inline_mod and mom_cap_outputlog.F90 made
consistent w/ MOM6 style
* several docstrings added or moved; spurious whitespace and comments
removed
* two word end if and end do changed to one word

* Fixes for flang

* Change variable not type

---------

Co-authored-by: jiandewang <jiande.wang@noaa.gov>
Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Co-authored-by: Marshall Ward <marshall.ward@noaa.gov>
Co-authored-by: Matthew Thompson <matthew.thompson@nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adcroft adcroft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zhi-Liang @adcroft