(*)Correct inconsistent units in 17 diagnostics#1385
Merged
Conversation
Corrects inconsistent units or unit conversion factors for 17 diagnostics plus all of the diagnostics for extra tracer fluxes where the scaling factor is not explicitly supplied (temperature and salinity are not impacted). In most cases the corrections are in obscure diagnostics that are probably not used much or only apply to non-Boussinesq cases. In addition, dimensional rescaling in time was applied to the diapycnal velocity diagnostic in layered mode. This commit addresses the specific problems noted in MOM6 issue mom-ocean#1384, but it does not uniformly change to the suggested code construct for register_diag_field arguments that would make these problems easier to detect in the future. All solutions are bitwise identical, but there are changes to the metadata of some diagnostics and there are changes to the available_diags files.
Collaborator
marshallward
approved these changes
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected inconsistent units or unit conversion factors for 17 diagnostics
plus all of the diagnostics for extra tracer fluxes where the scaling factor is
not explicitly supplied (temperature and salinity are not impacted). In most
cases the corrections are in obscure diagnostics that are probably not used much
or only apply to non-Boussinesq cases. In addition, dimensional rescaling in
time was applied to the diapycnal velocity diagnostic in layered mode. This
commit addresses the specific problems noted in MOM6 issue #1384, but it does
not uniformly change to the suggested code construct for register_diag_field
arguments that would make these problems easier to detect in the future. All
solutions are bitwise identical, but there are changes to the metadata of some
diagnostics and there are changes to the available_diags files.