Testing: Recurse target submodules, LDFLAGS hook#1355
Merged
Conversation
Two minor changes to the .testing build: - We now apply `--recurse-submodules` to the target build in the regression test. This is required after an update to the submodules, when the target submodule is out of sync with the main branch (e.g. dev/gfdl at NOAA-GFDL). - A LDFLAGS_USER hook was added to the `.testing/Makefile` configuration, similar to the FCFLAGS_* hooks. This is required if the library dependencies do not reside in the default directores. For example, this may be needed for a custom netCDF or MPI library.
Collaborator
Author
|
Now that Gaea is running .testing, it probably makes sense to start testing these: |
adcroft
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor changes to the .testing build:
We now apply
--recurse-submodulesto the target build in theregression test. This is required after an update to the submodules,
when the target submodule is out of sync with the main branch (e.g.
dev/gfdl at NOAA-GFDL).
A LDFLAGS_USER hook was added to the
.testing/Makefileconfiguration, similar to the FCFLAGS_* hooks. This is required if
the library dependencies do not reside in the default directores.
For example, this may be needed for a custom netCDF or MPI library.