Bugfix: empty restart_input_dir for *_solo.res#1348
Merged
marshallward merged 2 commits intoMar 9, 2021
Conversation
This commit fixes the issue that dirs%restart_input_dir is not initiated before "ocean_solo.res" and "ice_solo.res" are read.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1348 +/- ##
=========================================
Coverage 45.82% 45.83%
=========================================
Files 234 234
Lines 72661 72662 +1
=========================================
+ Hits 33300 33301 +1
Misses 39361 39361
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Mar 9, 2021
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree that these changes to correct the problem identified in Issue #1313, and that they are the right solution.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ocean/ice solo drivers look for "ocean_solo.res" and "ice_solo.res" in
dirs%restart_input_dir. However,dirsis only initiated after the call offile_existfor the ".res" files.This PR fixes this issue (https://github.com/NOAA-GFDL/MOM6/issues/1313) by moving
get_MOM_inputinice_self_driver.F90and adding an additionalget_MOM_inputinMOM_driver.F90, respectively.