Update CVMix submodule#1344
Merged
Merged
Conversation
- Tag v0.93-beta of CVMix is the last tag on their "master" branch before an API change within CVMix. - Answers reproduce with the three-year prior commit being used, as tested in MOM6-examples single_column cases. These do not cover all CVMix code.
- This tag involves an API change that requires changes to MOM_tidal_mixing.F90. - Changes are dropped arguments so presumably that data is not needed. - Answers reproduce in so far as they are covered by MOM6-examples. Not all of CVMix is covered in these tests and this code in particular is not.
- v0.98-beta is the latest tag of CVMix that is available a.t.t. - There were no API changes since the v0.94b-beta that affected MOM6. - No answer changes for MOM6-examples, but these do not exercise much of CVMix.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1344 +/- ##
=========================================
Coverage 45.83% 45.83%
=========================================
Files 234 234
Lines 72663 72663
=========================================
Hits 33302 33302
Misses 39361 39361
Continue to review full report at Codecov.
|
Collaborator
|
We use some of the modules touched here and I can confirm that this PR does not change answers for us. |
Collaborator
marshallward
approved these changes
Mar 12, 2021
Collaborator
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
I don't see any obvious answer changes, just some refactoring and maybe some new options. So given that and no detected regressions, presumably this is safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will point the CVMix submodule to the latest tag available, and was implemented in three consecutive commits:
Each commit was tested on MOM6-examples and GH actions. No answer changes were detected but MOM_tidal_mixing.F90 is not exercised in any of our tests. Providing the two intermediate commits provides finer granularity incase anyone has to
git bisectfor why CVMix changed answers.I suggest @gustavo-marques have a look at this PR since NCAR is most likely to be using these modules.