dynamic ice shelf#1338
Conversation
MOM_ice_shelf_dynamics.F90 modified initialize_ice_shelf_boundary_channel in MOM_ice_shelf_initialze.F90
Merge branch 'revert_drivers' of https://github.com/MJHarrison-GFDL/MOM6 into matts-revert-drivers
…e ice-shelf_fields consistent with diag_table Modifications to MOM_ice_shelf.F90 to apply melting to the case of a dynamic ice shelf.
v_bdry_val through halo
due to sub-ice-shelf melting
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1338 +/- ##
============================================
- Coverage 45.82% 45.73% -0.10%
============================================
Files 234 234
Lines 72667 72821 +154
============================================
Hits 33302 33302
- Misses 39365 39519 +154
Continue to review full report at Codecov.
|
|
@OlgaSergienko Can you look into some of the issues here? I'm seeing several trailing whitespace and line length errors, as well as a few undocumented variables. https://github.com/NOAA-GFDL/MOM6/pull/1338/checks?check_run_id=1974152973 |
|
Given that this PR includes extensive changes to a portion of the code, this PR should come with a more thorough description of what was done in the PR as a whole, why it was done, how it was tested (including which tests are passing or failing), and under what conditions changes should be expected to either solutions or output. |
|
There are many blocks of commented code in this PR, and it's not clear why they need to remain. Is it possible to remove them? |
It is possible. What other changes are required? Suggestions/recommendations are welcomed and appreciated. |
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12278. |
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have examined these revised changes, and I agree with these code modifications.
3 participants
Several bugs were corrected in MOM6_ice_dynamics.F90. MOM6_ice_shelf.F90 runs with DYNAMIC_SHELF_MASS = TRUE
Two test cases exercise the dynamic ice-shelf code with MOM6 rho
/lustre/f2/dev/gfdl/Olga.Sergienko/MOM6expls/ocean_only/ice_shelf_solo/IS2Dincl_plane_rho/
and layer mode
/lustre/f2/dev/gfdl/Olga.Sergienko/MOM6expls/ocean_only/ice_shelf_solo/IS2Dincl_plane_layer/