Skip to content

*Bugfix for ALE sponges (pass non-zero target thickness to remapping)#1332

Closed
MJHarrison-GFDL wants to merge 3 commits into
mom-ocean:dev/gfdlfrom
MJHarrison-GFDL:ALE_sponge_fix_022321
Closed

*Bugfix for ALE sponges (pass non-zero target thickness to remapping)#1332
MJHarrison-GFDL wants to merge 3 commits into
mom-ocean:dev/gfdlfrom
MJHarrison-GFDL:ALE_sponge_fix_022321

Conversation

@MJHarrison-GFDL
Copy link
Copy Markdown
Contributor

@MJHarrison-GFDL MJHarrison-GFDL commented Feb 23, 2021

- this addresses a bug in the apply_ALE_sponge routine which
had been passing zero values to the remapping routine for the
target grid thicknesses. This bug was identified by @abocez 

	- this addresses a bug in the apply_ALE_sponge routine which
  	had been passing zero values to the remapping routine for the
	target grid thicknesses.
@adcroft
Copy link
Copy Markdown
Collaborator

adcroft commented Feb 23, 2021

Can you also send this to the dev-gfdl-main-candidate-2021-02-19 branch? We're patching that first.

@marshallward
Copy link
Copy Markdown
Collaborator

  1. Do you want to remove the print statements?
  2. Let's update h_col instead of passing h(i,j,:), if only to follow the style guide (and avoid the implicit copy)
  3. This should go to the dev candidate rather than dev/gfdl.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2021

Codecov Report

Merging #1332 (cc1dee4) into dev/gfdl (45b3366) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1332   +/-   ##
=========================================
  Coverage     45.74%   45.74%           
=========================================
  Files           234      234           
  Lines         72540    72540           
=========================================
  Hits          33187    33187           
  Misses        39353    39353           
Impacted Files Coverage Δ
src/parameterizations/vertical/MOM_ALE_sponge.F90 26.56% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b3366...9048966. Read the comment docs.

@MJHarrison-GFDL
Copy link
Copy Markdown
Contributor Author

1. Do you want to remove the print statements?

2. Let's update `h_col` instead of passing `h(i,j,:)`, if only to follow the style guide (and avoid the implicit copy)

3. This should go to the dev candidate rather than `dev/gfdl`.

@marshallward
Copy link
Copy Markdown
Collaborator

@marshallward
Copy link
Copy Markdown
Collaborator

Handled in #1333, closing.

@MJHarrison-GFDL MJHarrison-GFDL deleted the ALE_sponge_fix_022321 branch April 10, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants