Testing: results cleanup fix#1241
Merged
Merged
Conversation
Fixing another minor issue related to wiping of empty test directories
in `results`.
1. std.{out,err} logs are now wiped prior to running the test, rather
than wiping them prior to the
This might be logically equivalent, but its better to wipe them in
the rule which creates the new ones, and seems to avoid additional
edge cases.
2. $(shell ls -A ${dir}) needs to be quoted in order for the shell to
test the results, which are now added.
adcroft
approved these changes
Nov 3, 2020
Collaborator
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Erroneous warnings are cleared up as a bonus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing another minor issue related to wiping of empty test directories
in
results.std.{out,err} logs are now wiped prior to running the test, rather
than wiping them prior to the
This might be logically equivalent, but its better to wipe them in
the rule which creates the new ones, and seems to avoid additional
edge cases.
test the results, which are now added.