Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
975262d
Merge pull request #5 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Oct 8, 2018
b7f50fc
Merge remote-tracking branch 'GFDL_MOM6/dev/gfdl' into dev/gfdl
Nov 7, 2018
9aa2aae
Merge pull request #7 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Nov 28, 2018
1bbc8de
Merge pull request #8 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Feb 5, 2019
522069b
Merge pull request #9 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Feb 27, 2019
1304880
Merge pull request #10 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Mar 21, 2019
30d35a3
Merge pull request #11 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Mar 28, 2019
6ffc897
Merge pull request #12 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Apr 8, 2019
f5bc54b
Merge pull request #13 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Apr 15, 2019
a1c556b
Merge pull request #14 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Apr 18, 2019
42cca4f
Merge pull request #15 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Apr 25, 2019
a0c80dc
Merge pull request #16 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Apr 26, 2019
139ab1f
Merge pull request #17 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor May 9, 2019
f6879f4
Merge pull request #18 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor May 17, 2019
b4fd53b
Merge pull request #19 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor May 24, 2019
601eb67
Merge pull request #20 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jun 5, 2019
911d0a2
Merge pull request #21 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jun 20, 2019
b5e5c48
Merge pull request #22 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 3, 2019
aa11e1f
Merge pull request #23 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 23, 2019
5589d8c
Merge pull request #24 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 29, 2019
5772083
Merge pull request #25 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 31, 2019
f9b5a7f
Merge pull request #26 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Aug 12, 2019
22c5865
Merge pull request #27 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Aug 28, 2019
5b2852c
Merge pull request #28 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Sep 26, 2019
a5386da
Merge pull request #30 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Oct 2, 2019
0b874f3
Merge pull request #31 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Oct 4, 2019
a427676
Merge pull request #32 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Oct 22, 2019
124a071
Merge pull request #33 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Nov 12, 2019
09bcebc
Merge pull request #35 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Nov 19, 2019
2c32568
merge in latest dev/gfdl updates (#36)
wrongkindofdoctor Nov 28, 2019
855d706
Merge in dev/gfdl updates (#37)
wrongkindofdoctor Dec 2, 2019
3c15a0c
Revert "Merge in dev/gfdl updates (#37)"
wrongkindofdoctor Dec 2, 2019
5910903
Merge pull request #38 from wrongkindofdoctor/revert-37-dev/gfdl
wrongkindofdoctor Dec 2, 2019
3e27e47
Merge branch 'dev/gfdl' of git://github.com/NOAA-GFDL/MOM6 into NOAA-…
Dec 3, 2019
ece60c1
Merge branch 'NOAA-GFDL-dev/gfdl' into dev/gfdl
Dec 3, 2019
cae4cfd
Merge branch 'dev/gfdl' of github.com:wrongkindofdoctor/MOM6 into dev…
Dec 3, 2019
e072bc7
Merge in latest dev/gfdl updates (#40)
wrongkindofdoctor Dec 6, 2019
075ab81
Merge pull request #41 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Dec 9, 2019
abaf004
Merge pull request #42 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Dec 17, 2019
162ca97
Merge pull request #43 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jan 6, 2020
7dbca83
Merge pull request #44 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jan 13, 2020
12dccaf
Merge pull request #46 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jan 17, 2020
cee0a21
Merge pull request #47 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Feb 3, 2020
477d9f8
Merge pull request #48 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Feb 10, 2020
aff2a13
Merge pull request #49 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Feb 14, 2020
7adcc90
Merge pull request #50 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Feb 26, 2020
8d7be68
Merge pull request #51 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Mar 9, 2020
c245357
Merge pull request #52 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Mar 16, 2020
86c2a7d
Merge pull request #53 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Mar 30, 2020
4a56134
Merge pull request #54 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Apr 8, 2020
e9281f4
Merge pull request #55 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Apr 20, 2020
496617c
Merge pull request #56 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor May 1, 2020
ff1a27f
Merge pull request #57 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor May 7, 2020
46b8f0f
Merge pull request #58 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor May 26, 2020
b8eee45
Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl
Jun 5, 2020
cea55fe
Merge pull request #59 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jun 9, 2020
ff34126
Merge pull request #60 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 7, 2020
763b176
Merge pull request #61 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 13, 2020
cbdcf8a
Create hola_tierra.yml
wrongkindofdoctor Jul 17, 2020
50c3539
Merge pull request #62 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 22, 2020
de7f95a
Merge pull request #63 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 28, 2020
0cf3cb9
Merge pull request #64 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Jul 31, 2020
c8695c6
Merge pull request #65 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Aug 17, 2020
40047fa
Merge pull request #66 from NOAA-GFDL/dev/gfdl
wrongkindofdoctor Aug 24, 2020
5c2daa5
converted save_restart and restore_state to interface that call versi…
Jul 8, 2020
a74c7ea
changed FMS release to 2020.03-beta1
Jul 31, 2020
809b3ac
added local logical variables to save restart wrapper that are set us…
Jul 31, 2020
2e46ea6
removed errant .true. in save_restart call
Aug 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .testing/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ MKMF := $(abspath $(DEPS)/mkmf/bin/mkmf)

# FMS framework
FMS_URL ?= https://github.com/NOAA-GFDL/FMS.git
FMS_COMMIT ?= 2019.01.03
FMS_COMMIT ?= 2020.03-beta1
FMS := $(DEPS)/fms

#---
Expand Down
4 changes: 2 additions & 2 deletions src/core/MOM.F90
Original file line number Diff line number Diff line change
Expand Up @@ -2782,9 +2782,9 @@ subroutine finish_MOM_initialization(Time, dirs, CS, restart_CSp)
call find_eta(CS%h, CS%tv, G, GV, US, z_interface, eta_to_m=1.0)
call register_restart_field(z_interface, "eta", .true., restart_CSp_tmp, &
"Interface heights", "meter", z_grid='i')

! NOTE: write_ic=.true. routes routine to fms2 IO write_initial_conditions interface
call save_restart(dirs%output_directory, Time, CS%G_in, &
restart_CSp_tmp, filename=CS%IC_file, GV=GV)
restart_CSp_tmp, filename=CS%IC_file, GV=GV, write_ic=.true.)
deallocate(z_interface)
deallocate(restart_CSp_tmp)
endif
Expand Down
625 changes: 625 additions & 0 deletions src/framework/MOM_axis.F90

Large diffs are not rendered by default.

530 changes: 521 additions & 9 deletions src/framework/MOM_io.F90

Large diffs are not rendered by default.

1,529 changes: 1,529 additions & 0 deletions src/framework/MOM_read_data_fms2.F90

Large diffs are not rendered by default.

958 changes: 947 additions & 11 deletions src/framework/MOM_restart.F90

Large diffs are not rendered by default.

29 changes: 29 additions & 0 deletions src/framework/MOM_string_functions.F90
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ module MOM_string_functions
public extract_real
public remove_spaces
public slasher
public append_substring

contains

Expand Down Expand Up @@ -419,6 +420,34 @@ function slasher(dir)
endif
end function slasher

!> append a string (substring) to another string (string_in) and return the
!! concatenated string (string_out)
function append_substring(string_in, substring) result(string_out)
character(len=*), intent(in) :: string_in !< input string
character(len=*), intent(in) :: substring !< string to append string_in
! local
character(len=1024) :: string_out
character(len=1024) :: string_joined
integer :: string_in_length
integer :: substring_length

string_out = ''
string_joined = ''
string_in_length = 0
substring_length = 0

string_in_length = len_trim(string_in)
substring_length = len_trim(substring)

if (string_in_length > 0) then
if (substring_length > 0) then
string_joined = trim(string_in)//trim(substring)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under what circumstances would replacing this function with trim(string_in)//trim(substring) not work?

Copy link
Copy Markdown
Contributor Author

@wrongkindofdoctor wrongkindofdoctor Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented this routine to ensure that the full file path was correctly rendered since I was having issues with blank spaces and string length mis-matches when trying to append ".nc" to file paths in save_restart and write_initial conditions. The routine ensures that the concatenated strings "fit" in the string returned by the routine, as str_out and str_joined are both size 1024, whereas save_restart procedure of str1=str1//str2 does not.

string_out(1:len_trim(string_joined)) = trim(string_joined)
endif
endif

end function append_substring

!> \namespace mom_string_functions
!!
!! By Alistair Adcroft and Robert Hallberg, last updated Sept. 2013.
Expand Down
1,663 changes: 1,663 additions & 0 deletions src/framework/MOM_write_field_fms2.F90

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions src/ice_shelf/MOM_ice_shelf.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1512,8 +1512,8 @@ subroutine initialize_ice_shelf(param_file, ocn_grid, Time, CS, diag, forces, fl
elseif (.not.new_sim) then
! This line calls a subroutine that reads the initial conditions from a restart file.
call MOM_mesg("MOM_ice_shelf.F90, initialize_ice_shelf: Restoring ice shelf from file.")
call restore_state(dirs%input_filename, dirs%restart_input_dir, Time, &
G, CS%restart_CSp)
call restore_state(dirs%input_filename, dirs%restart_input_dir, Time, &
G, CS%restart_CSp)

if ((US%m_to_Z_restart /= 0.0) .and. (US%m_to_Z_restart /= US%m_to_Z)) then
Z_rescale = US%m_to_Z / US%m_to_Z_restart
Expand Down Expand Up @@ -1587,7 +1587,7 @@ subroutine initialize_ice_shelf(param_file, ocn_grid, Time, CS, diag, forces, fl
if (save_IC .and. .not.((dirs%input_filename(1:1) == 'r') .and. &
(LEN_TRIM(dirs%input_filename) == 1))) then
call save_restart(dirs%output_directory, CS%Time, G, &
CS%restart_CSp, filename=IC_file)
CS%restart_CSp, filename=IC_file, write_ic=.true.)
endif


Expand Down