*Corrected two bugs impacting .testing test cases#1129
Merged
Conversation
Corrected the velocities that are used in the call to set_viscous_ML with SPLIT=False and USE_RK2=True. This call had used the partially updated predictor velocities, which included other accelerations but not viscosity and which was missing a halo update, so it would not reproduce between symmetric and non-symmetric modes or across PE counts. This combination of parameters is not used in the MOM6-examples test suite, but it does change answers in some of the test cases in .testing. Also removed CORRECT_DENSITY=False from tc4/MOM_input, so that this test will not fail after this parameter is obsoleted. All answers and output in the MOM6-examples test suite are bitwise identical, but there are deliberate changes in the answers in the .testing test cases.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1129 +/- ##
=========================================
Coverage 45.99% 45.99%
=========================================
Files 215 215
Lines 69577 69577
=========================================
Hits 32000 32000
Misses 37577 37577
Continue to review full report at Codecov.
|
Collaborator
Author
|
This failed regression test is deliberate. The previous solution would have failed symmetry testing if it had run longer. |
Collaborator
|
Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10537 Regression has passed. |
marshallward
approved these changes
Jun 9, 2020
This was referenced Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the velocities that are used in the call to set_viscous_ML with
SPLIT=False and USE_RK2=True. This call had used the partially updated
predictor velocities, which included other accelerations but not viscosity and
which was missing a halo update, so it would not reproduce between symmetric and
non-symmetric modes or across PE counts. This combination of parameters is not
used in the MOM6-examples test suite, but it does change answers in some of the
test cases in .testing. Also removed CORRECT_DENSITY=False from tc4/MOM_input,
so that this test will not fail after this parameter is obsoleted. All answers
and output in the MOM6-examples test suite are bitwise identical, but there are
deliberate changes in the answers in the .testing test cases.