Skip to content

Fixes an integer-kind mismatch in MOM_random, seed_from_time() #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adcroft merged 1 commit into from
May 19, 2020
Merged

Fixes an integer-kind mismatch in MOM_random, seed_from_time() #1113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/framework/MOM_random.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,9 @@ integer function seed_from_time(Time)
call get_date(Time,yr,mo,dy,hr,mn,sc)
s1 = sc + 61*(mn + 61*hr) + 379 ! Range 379 .. 89620
! Fun fact: 2147483647 is the eighth Mersenne prime.
! This is not the reason for using 2147483647+1 here.
s2 = mod(dy + 32*(mo + 13*yr), 2147483648) ! Range 0 .. 2147483647
! This is not the reason for using 2147483647 here. It is the
! largest integer of kind=4.
s2 = modulo(dy + 32*(mo + 13*yr), 2147483647_4) ! Range 0 .. 2147483646
seed_from_time = ieor(s1*4111, s2)

end function seed_from_time
Expand Down