Skip to content

Reduced output during testing#1110

Merged
adcroft merged 6 commits into
mom-ocean:dev/gfdlfrom
marshallward:small_log
May 15, 2020
Merged

Reduced output during testing#1110
adcroft merged 6 commits into
mom-ocean:dev/gfdlfrom
marshallward:small_log

Conversation

@marshallward
Copy link
Copy Markdown
Collaborator

The Makefile has been modified to reduce the amount of output during testing. Output is generally omitted on a successful test. When a test fails, we only display a small portion of the total output.

We also now run all tests, even if they fail, in order to give a complete profile of the test failures.

Regression testing rules have been integrated into the general rules.

Finally, Travis config has been modified to further reduce output, and to run all of tests (make -k).

marshallward and others added 5 commits May 14, 2020 15:52
The Makefile has been modified to reduce the amount of output during
testing.  Output is generally omitted on a successful test.  When a test
fails, we only display a small portion of the total output.

We also now run all tests, even if they fail, in order to give a
complete profile of the test failures.

Regression testing rules have been integrated into the general rules.

Finally, Travis config has been modified to further reduce output, and
to run all of tests (make -k).
Test logging is now much shorter, so folding is less important.
CodeCov reporting log is now saved to results/ rather than piped to
stdout, further reducing test logging output.
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 14, 2020

Codecov Report

Merging #1110 into dev/gfdl will increase coverage by 0.00%.
The diff coverage is 1.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1110   +/-   ##
=========================================
  Coverage     46.06%   46.07%           
=========================================
  Files           214      214           
  Lines         69361    69352    -9     
=========================================
- Hits          31954    31952    -2     
+ Misses        37407    37400    -7     
Impacted Files Coverage Δ
src/core/MOM.F90 65.77% <0.00%> (ø)
src/ice_shelf/MOM_ice_shelf.F90 0.00% <0.00%> (ø)
...c/parameterizations/lateral/MOM_internal_tides.F90 0.00% <0.00%> (ø)
...rc/parameterizations/vertical/MOM_tidal_mixing.F90 10.51% <0.00%> (+0.01%) ⬆️
src/tracer/ISOMIP_tracer.F90 0.00% <0.00%> (ø)
src/tracer/MOM_lateral_boundary_diffusion.F90 69.30% <0.00%> (+0.01%) ⬆️
src/tracer/MOM_offline_main.F90 0.00% <0.00%> (ø)
src/parameterizations/vertical/MOM_ALE_sponge.F90 26.60% <8.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7766a...c233e02. Read the comment docs.

We were saving codecov output to results, but this was breaking the
`test.summary` test, which only returns true if `results` is empty.

This change should resolve this issue.
@marshallward
Copy link
Copy Markdown
Collaborator Author

This seems good enough to merge from my end, but there is no hurry and plenty of room for feedback.

@marshallward marshallward changed the title Small log Reduced output during testing May 15, 2020
@marshallward
Copy link
Copy Markdown
Collaborator Author

Sample output from a run with answer changes:

https://travis-ci.org/github/marshallward/MOM6/jobs/687177632

Copy link
Copy Markdown
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in the syntax of Makefiles, so I will leave it to others to approve these changes, but the sample output showing the new log for a deliberately errant commit immediately shows that that this commit leads to a vast improvement over what was coming out before. Very well done, @marshallward !

Copy link
Copy Markdown
Collaborator

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master of make.

@adcroft adcroft merged commit 8f57abf into mom-ocean:dev/gfdl May 15, 2020
@marshallward marshallward deleted the small_log branch September 2, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants