Scalar diag conversion; Q and R dimension scaling#1103
Merged
Conversation
This patch adds support for enthalpy (Q) and density (R) dimensional scaling into the test suite. It also resolves an issue with conversion scaling in scalars (post_data_0d) which were not being applied, and make it impossible to verify the dimensions of scalar diagnostics.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1103 +/- ##
============================================
- Coverage 45.76% 43.52% -2.25%
============================================
Files 215 214 -1
Lines 69638 69361 -277
============================================
- Hits 31872 30186 -1686
- Misses 37766 39175 +1409
Continue to review full report at Codecov.
|
Collaborator
|
The pipeline tests on this commit are at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10335. |
Hallberg-NOAA
approved these changes
May 4, 2020
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This contribution is useful and correct, bringing the treatment of the conversion factor in post_data_0d into consistency with the other versions of post_data, and expanding the range of units subject to automated testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for enthalpy (Q) and density (R) dimensional
scaling into the test suite.
It also resolves an issue with conversion scaling in scalars
(post_data_0d) which were not being applied, and make it impossible to
verify the dimensions of scalar diagnostics.