MOM6: +Make wave speed calculations more robust via new options#1096
Merged
marshallward merged 2 commits intoApr 29, 2020
Conversation
Added new options to control the wave speed calculation. These are set with optional arguments to wave_speed_init, wave_speed_set_params, wave_speed and wave_speeds, which are set with the runtime parameters INTERNAL_WAVE_SPEED_TOL, INTERNAL_WAVE_SPEED_MIN, and INTERNAL_WAVE_SPEED_BETTER_EST. Also altered the internal scaling of velocity to make cascading underflows leading to NaNs less likely. By default all answers are bitwise identical, but there are three new runtime parameters and new optional arguments to 4 public interfaces.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1096 +/- ##
============================================
- Coverage 45.79% 45.77% -0.02%
============================================
Files 215 215
Lines 69484 69602 +118
============================================
+ Hits 31819 31860 +41
- Misses 37665 37742 +77
Continue to review full report at Codecov.
|
Collaborator
Author
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10265 . |
Collaborator
|
Updated regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10286 |
marshallward
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new options to control the wave speed calculation. These are set with
optional arguments to wave_speed_init, wave_speed_set_params, wave_speed and
wave_speeds, which are set with the runtime parameters INTERNAL_WAVE_SPEED_TOL,
INTERNAL_WAVE_SPEED_MIN, and INTERNAL_WAVE_SPEED_BETTER_EST. Also altered the
internal scaling of velocity to make cascading underflows leading to NaNs less
likely. By default all answers are bitwise identical, but there are three new
runtime parameters and new optional arguments to 4 public interfaces.