Skip to content

Fix bug and unit tests in LBD#1092

Merged
marshallward merged 3 commits into
mom-ocean:dev/gfdlfrom
gustavo-marques:fix_LBD_tests
Apr 22, 2020
Merged

Fix bug and unit tests in LBD#1092
marshallward merged 3 commits into
mom-ocean:dev/gfdlfrom
gustavo-marques:fix_LBD_tests

Conversation

@gustavo-marques
Copy link
Copy Markdown
Collaborator

Unit tests in the LBD were broken because 1) the syntax was incorrect (as pointed by @adcroft ), and 2) there was a bug in the bulk layer method. Both are fixed now and all unit tests are passing.

I've also fixed a string continuation syntax in MOM_tracer_registry.F90, caught by gcc 4.9.2.

@gustavo-marques gustavo-marques changed the title Fix bug in bulk layer method and unit tests in lateral boundary diffusion Fix bug in bulk layer method and unit tests in LBD Apr 17, 2020
@gustavo-marques gustavo-marques changed the title Fix bug in bulk layer method and unit tests in LBD Fix bug and unit tests in LBD Apr 17, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 21, 2020

Codecov Report

Merging #1092 into dev/gfdl will decrease coverage by 0.00%.
The diff coverage is 89.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1092      +/-   ##
============================================
- Coverage     45.80%   45.79%   -0.01%     
============================================
  Files           215      215              
  Lines         69480    69484       +4     
============================================
- Hits          31822    31819       -3     
- Misses        37658    37665       +7     
Impacted Files Coverage Δ
src/tracer/MOM_tracer_registry.F90 89.65% <ø> (ø)
src/tracer/MOM_lateral_boundary_diffusion.F90 69.41% <88.00%> (-1.07%) ⬇️
src/framework/MOM_diag_mediator.F90 63.71% <100.00%> (ø)
src/framework/MOM_diag_remap.F90 92.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c505ad3...6e2f334. Read the comment docs.

@Hallberg-NOAA
Copy link
Copy Markdown
Collaborator

This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10245.

Copy link
Copy Markdown
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my visual inspection, this PR seems to be correct and reasonable. As this is a newer capability that is not being directly exercised by the MOM6-examples test suite, I will have to go on the assumption that this was properly tested by its trustworthy developer. Although this appears to add new run-time parameters, this change is conditional, and the MOM6-examples tests are not exhibiting changes to their MOM_parameter_doc files. However, the available_diags file does change, so this PR will have to be done by hand.

@marshallward marshallward merged commit 178d429 into mom-ocean:dev/gfdl Apr 22, 2020
@gustavo-marques gustavo-marques deleted the fix_LBD_tests branch April 21, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants