Fix bug and unit tests in LBD#1092
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1092 +/- ##
============================================
- Coverage 45.80% 45.79% -0.01%
============================================
Files 215 215
Lines 69480 69484 +4
============================================
- Hits 31822 31819 -3
- Misses 37658 37665 +7
Continue to review full report at Codecov.
|
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10245. |
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Based on my visual inspection, this PR seems to be correct and reasonable. As this is a newer capability that is not being directly exercised by the MOM6-examples test suite, I will have to go on the assumption that this was properly tested by its trustworthy developer. Although this appears to add new run-time parameters, this change is conditional, and the MOM6-examples tests are not exhibiting changes to their MOM_parameter_doc files. However, the available_diags file does change, so this PR will have to be done by hand.
Unit tests in the LBD were broken because 1) the syntax was incorrect (as pointed by @adcroft ), and 2) there was a bug in the bulk layer method. Both are fixed now and all unit tests are passing.
I've also fixed a string continuation syntax in MOM_tracer_registry.F90, caught by gcc 4.9.2.