Remove G_EARTH from OBCs#1090
Merged
Merged
Conversation
- The parameter G_EARTH is unnecessarily read and logged by OBCs. This is normally innocuous except PR #1088 rearranges the call order between OBCs and vertGrid which puts G_EARTH in the wrong block in the doc files. - This removes G_EARTH from OBCs so it is not logged and the two outstanding PRs (#1088 and #1089) don't move G_EARTH to the wrong place. - This PR on its own does not change the doc files prior to #1088.
Hallberg-NOAA
approved these changes
Apr 15, 2020
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This change makes good sense to me. I approve this PR.
- This branch/PR had been setup to precede NOAA-GFDL#1088 to minimize changes to MOM6-examples but @Hallberg-NOAA jumped the gun and merged the PRs out of order. - This commit resolves the conflict and MOM6-examples needs to be fixed.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1090 +/- ##
============================================
- Coverage 46.26% 45.81% -0.45%
============================================
Files 213 215 +2
Lines 67954 69133 +1179
============================================
+ Hits 31436 31671 +235
- Misses 36518 37462 +944
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Apr 16, 2020
Collaborator
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I approve this amendment.
Collaborator
|
Updated Gaea regression test has passed, merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is normally innocuous except PR Internal field index rotation #1088 rearranges the call
order between OBCs and vertGrid which puts G_EARTH in the wrong
block in the doc files.
outstanding PRs (Internal field index rotation #1088 and MOM6: +(*)Rescale pressures #1089) don't move G_EARTH to the
wrong place.