MOM6: +Additional code cleanup#1078
Merged
Merged
Conversation
Rescaled the units of the area_shelf_h variable used to initialize frac_shelf_h, and eleminated the unused g_Earth element in the ocean_grid_type. All answers are bitwise identical, but an element was removed from a transparent public type.
Corrected additional documented units in comments, corrected spelling errors in comments and removed unused variables. Also noted some probable dimensional consistency errors in MOM_open_boundary.F90. All answers are bitwise identical.
Collaborator
Author
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10045. |
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1078 +/- ##
============================================
- Coverage 45.96% 45.96% -0.01%
============================================
Files 212 212
Lines 67351 67350 -1
============================================
- Hits 30961 30959 -2
- Misses 36390 36391 +1
Continue to review full report at Codecov.
|
marshallward
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes another batch of minor changes to clean up the MOM6 code,
including corrections to comments, removing unused variables from subroutines
and the ocean_grid_type, noting a probable dimensional inconsistency in comments
in MOM_open_boundary.F90, and rescaling a variable used to set area_shelf_h.
There are no changes to solutions, diagnostics, or output files. The commits in
this PR include: