Skip to content

Corrected the units in ALE variable documentation#1076

Merged
marshallward merged 2 commits into
mom-ocean:dev/gfdlfrom
Hallberg-NOAA:document_ALE_vars
Mar 19, 2020
Merged

Corrected the units in ALE variable documentation#1076
marshallward merged 2 commits into
mom-ocean:dev/gfdlfrom
Hallberg-NOAA:document_ALE_vars

Conversation

@Hallberg-NOAA
Copy link
Copy Markdown
Collaborator

Added or corrected comments describing the units of many of the variables in
the ALE code. All solutions are bitwise identical, although there are some
unit changes in arguments to unused subroutines.

  Added or corrected comments describing the units of many of the variables in
the ALE code.  All solutions are bitwise identical, although there are some
unit changes in arguments to unused subroutines.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 17, 2020

Codecov Report

Merging #1076 into dev/gfdl will decrease coverage by 0.28%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1076      +/-   ##
============================================
- Coverage     45.98%   45.69%   -0.29%     
============================================
  Files           212      212              
  Lines         67332    67336       +4     
============================================
- Hits          30960    30769     -191     
- Misses        36372    36567     +195     
Impacted Files Coverage Δ
src/ALE/coord_hycom.F90 0.00% <0.00%> (ø)
src/ALE/coord_rho.F90 16.36% <0.00%> (-0.41%) ⬇️
src/ALE/coord_slight.F90 0.00% <0.00%> (ø)
src/ALE/regrid_interp.F90 1.41% <0.00%> (+0.02%) ⬆️
src/ALE/MOM_regridding.F90 31.42% <29.41%> (-0.31%) ⬇️
src/ALE/coord_zlike.F90 77.55% <100.00%> (+0.95%) ⬆️
src/framework/MOM_diag_mediator.F90 63.43% <100.00%> (ø)
src/framework/MOM_diag_remap.F90 92.79% <100.00%> (ø)
...rc/parameterizations/lateral/MOM_tidal_forcing.F90 0.00% <0.00%> (-68.59%) ⬇️
src/core/MOM_PressureForce_analytic_FV.F90 41.07% <0.00%> (-3.12%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e3866...22ddb98. Read the comment docs.

@marshallward
Copy link
Copy Markdown
Collaborator

marshallward commented Mar 19, 2020

Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10043

Test has passed; no regressions.

@marshallward marshallward merged commit 9603f69 into mom-ocean:dev/gfdl Mar 19, 2020
@Hallberg-NOAA Hallberg-NOAA deleted the document_ALE_vars branch July 30, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants