+Corrected doc_param_time#1075
Merged
marshallward merged 2 commits intoMar 19, 2020
Merged
Conversation
Rewrote the subroutine doc_param_time to work like the other doc_param routines, including making the units argument optional, removing the argument layout_param, and adding the new internally visible routine time_string. Because time variables are currently logged as real values using the timeunit argument to log_param_time, these changes do not have a widespread impact. All answers are bitwise identical, but there are some limited interface changes.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1075 +/- ##
============================================
- Coverage 45.98% 45.97% -0.01%
============================================
Files 212 212
Lines 67332 67343 +11
============================================
Hits 30960 30960
- Misses 36372 36383 +11
Continue to review full report at Codecov.
|
Collaborator
|
Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10042 Regression has passed. |
marshallward
approved these changes
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote the subroutine doc_param_time to work like the other doc_param
routines, including making the units argument optional, removing the argument
layout_param, and adding the new internally visible routine time_string.
Because time variables are currently logged as real values using the timeunit
argument to log_param_time, these changes do not have a widespread impact. All
answers are bitwise identical, but there are some limited interface changes.