+Corrected diagnostics and diagnostic units#1074
Merged
Merged
Conversation
Corrected the units reported for 9 diagnostics, and altered the code so that the diagnostics N2_u and N2_v are only offered if the can be calculated and the proper diagnostics are written if these diagnostics are requested (previously arrays of zeros were always output). All solutions are bitwise identical, but some diagostics in output files change and the available_diags files have altered entries.
Collaborator
Author
|
The failed Travis check is due to changes in the values of two diagnostics, which had previously been reporting all 0 values, and offering diagnostics in some cases when they are not in fact available. Pipeline testing for this PR has been triggered (although I can not see the pipelines from outside of the GFDL building, so someone else will have to let me know the results). |
Collaborator
|
Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10010 The tests have passed up to a I have some major Lustre issue on Gaea (it currently takes me several hours to build+run the test), so someone else may need to do the parameter update. |
marshallward
approved these changes
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the units reported for 9 diagnostics, and altered the code so that
the diagnostics N2_u and N2_v are only offered if the can be calculated and the
proper diagnostics are written if these diagnostics are requested (previously
arrays of zeros were always output). All solutions are bitwise identical, but
some diagostics in output files change and the available_diags files have
altered entries.