Skip to content

+Corrected diagnostics and diagnostic units#1074

Merged
marshallward merged 1 commit into
mom-ocean:dev/gfdlfrom
Hallberg-NOAA:fix_diag_units
Mar 19, 2020
Merged

+Corrected diagnostics and diagnostic units#1074
marshallward merged 1 commit into
mom-ocean:dev/gfdlfrom
Hallberg-NOAA:fix_diag_units

Conversation

@Hallberg-NOAA
Copy link
Copy Markdown
Collaborator

Corrected the units reported for 9 diagnostics, and altered the code so that
the diagnostics N2_u and N2_v are only offered if the can be calculated and the
proper diagnostics are written if these diagnostics are requested (previously
arrays of zeros were always output). All solutions are bitwise identical, but
some diagostics in output files change and the available_diags files have
altered entries.

  Corrected the units reported for 9 diagnostics, and altered the code so that
the diagnostics N2_u and N2_v are only offered if the can be calculated and the
proper diagnostics are written if these diagnostics are requested (previously
arrays of zeros were always output).  All solutions are bitwise identical, but
some diagostics in output files change and the available_diags files have
altered entries.
@Hallberg-NOAA
Copy link
Copy Markdown
Collaborator Author

The failed Travis check is due to changes in the values of two diagnostics, which had previously been reporting all 0 values, and offering diagnostics in some cases when they are not in fact available.

Pipeline testing for this PR has been triggered (although I can not see the pipelines from outside of the GFDL building, so someone else will have to let me know the results).

@marshallward
Copy link
Copy Markdown
Collaborator

marshallward commented Mar 17, 2020

Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10010

The tests have passed up to a parameter diagnostic unit change, as expected.

I have some major Lustre issue on Gaea (it currently takes me several hours to build+run the test), so someone else may need to do the parameter update.

@marshallward marshallward merged commit 38024df into mom-ocean:dev/gfdl Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants