Travis bionic test#1071
Merged
Merged
Conversation
Moving FMS and mkmf to the `build` directory led to conflicts in the `build/%/Makefile` and `build/%/path_names` rules, which were causing redundant builds. This patch moves these repositories back into a local `deps` directory, now kept inside of `.testing`.
The Travis environment was updated in order to get a newer GCC compiler version. This was done to enable more aggressive initialization.
The FMS version has been updated in order to permit more aggressive initialization settings in MOM6. This requires a few bugfixes in the newer FMS release.
Flags for initializing reals on stack as signaling NaNs (SNaN) and integers as 2**31 - 1 have been added in this build.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1071 +/- ##
============================================
+ Coverage 45.52% 45.98% +0.45%
============================================
Files 211 212 +1
Lines 62690 67332 +4642
============================================
+ Hits 28541 30960 +2419
- Misses 34149 36372 +2223
Continue to review full report at Codecov.
|
adcroft
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes four major changes:
depsdirectory due to a clash of Makefile pattern rules.This will enforce stricter initialization rules in the source code, and may expose issues on other branches on a later
dev/mastermerge.