Source tree variable fix#1069
Merged
Merged
Conversation
This fixes a bug in the SOURCE variable which was used to track files during development. It is generally unused for test builds. This was reworked to include support for FMS and the target repository. `SOURCE` is now a Makefile function which support MOM6 and FMS trees. We also extended it to catch other extensions: .inc .c .h These variables are used to link the top Makefile to the mkmf-generated makefiles, in order to trigger a rebuild via mkmf-makefile changes. I would not expect these `SOURCE` dependents to persist if we move to the autoconf build system.
adcroft
approved these changes
Mar 5, 2020
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1069 +/- ##
============================================
- Coverage 45.52% 45.22% -0.31%
============================================
Files 211 211
Lines 62690 62690
============================================
- Hits 28541 28350 -191
- Misses 34149 34340 +191
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the SOURCE variable which was used to track files
during development. It is generally unused for test builds.
This was reworked to include support for FMS and the target repository.
SOURCEis now a Makefile function which support MOM6 and FMS trees.We also extended it to catch other extensions: .inc .c .h
These variables are used to link the top Makefile to the mkmf-generated
makefiles, in order to trigger a rebuild via mkmf-makefile changes.
I would not expect these
SOURCEdependents to persist if we move tothe autoconf build system.
This only affects the makefile used by Travis (and possibly users at command line) so should not require Gaea regression testing.