Switch from hbmqtt to amqtt, websockets 9#79
Conversation
requirements.txt
Outdated
| certifi | ||
| hbmqtt | ||
| websockets<=8.1 | ||
| amqtt |
There was a problem hiding this comment.
| amqtt | |
| amqtt>=0.10.0,<0.11.0 |
I would suggest to require at least 0.10.0. Looking at the changelog, this seems to be a good starting point. The upper bound is just in case any more additional breaking changes are introduced.
requirements.txt
Outdated
| hbmqtt | ||
| websockets<=8.1 | ||
| amqtt | ||
| websockets<10.0 |
There was a problem hiding this comment.
Is there a reason to limit it to <10.0? At least amqtt sets >=9.0.
If you would like to prevent issues in the future, may I suggest <11.0 instead? There are already libs in Home Assistant that require > 10.0.
Of course that depends on compatibility foremost.
https://websockets.readthedocs.io/en/stable/project/changelog.html#id2
| packages=["volvooncall"], | ||
| install_requires=list(open("requirements.txt").read().strip().split("\n")), | ||
| extras_require={"console": ["docopt"]}, | ||
| python_requires=">=3.8" |
There was a problem hiding this comment.
| python_requires=">=3.8" | |
| python_requires=">=3.7" |
3.7 should work too :)
There was a problem hiding this comment.
The package already only supports 3.8+ per the readme and CI workflow.
2 participants
Resolves #78
I have not verified this change, as I do not use the MQTT aspects of this package. So I'm opening this as a draft PR until someone else can verify that the changes work.