Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Types #62

Merged
merged 7 commits into from
Mar 11, 2022
Merged

Adds Types #62

merged 7 commits into from
Mar 11, 2022

Conversation

AndreMaz
Copy link
Member

@AndreMaz AndreMaz commented Mar 6, 2022

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@AndreMaz AndreMaz merged commit b3ab179 into master Mar 11, 2022
@AndreMaz AndreMaz deleted the types branch March 14, 2022 07:50
@shawnmcknight
Copy link
Member

@AndreMaz I noticed in moleculerjs/moleculer#1068 that the PR author added in some repl options. I took a look back at this PR to see if that was simply a mistake or if they were trying to fix additional things. One thing I noticed here is that the types are stored in a types subfolder, which is fine, but I think the package.json will need a types property pointing to location of the main index.d.ts file based on how TS resolves modules. If it was in the root folder it would resolve automatically, but being in a subfolder I think it will be missed. Let me know if you have any questions on that.

@AndreMaz
Copy link
Member Author

@shawnmcknight Thanks you for pointing this out 😉

Fixed: adb2541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants