Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgdate to latest Apollo server / subscriptions #118

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

code4bones
Copy link

  • upgrade to Apollo server v3 ( + switch from subscriptions-transport-ws to graphql-ws )
  • add Custom PubSub creator ( for use custom PubSubEngine )
  • add Update/Reload schema without restarting server/ws
  • Playground ( RenderPageOptions ) options in serverOptions.playgroundOptions
  • add serverOptions.subscriptions.onConnect should return acts lile graphql-ws
  • add serverOptions.subscriptions.context should return user account ( like "authenticate" method )
  • CAUTION: with new graphql-ws subscriptions are not available in build-in playground
  • WARNING: graphql-upload disabled ( new versions is mjs type )
  • Not tested - DataLoader
  • Example in examples/full/

@intech
Copy link
Member

intech commented Oct 24, 2022

Hello! Thanks for your contribution.
There are a few quick fixes but important ones:

  1. Look at the diff between the example files. There are a lot of changes that don't make sense for this PR.
  2. You cannot change the description and repository in package.json.
  3. A lot of commented code. If it is not needed, remove it.

@veeramarni
Copy link

veeramarni commented Dec 15, 2022

how soon this can be merged? Apollo server v2 is very outdated, and it needs to be in v3 atleast.

@icebob
Copy link
Member

icebob commented Dec 15, 2022

CI is failed

@intech
Copy link
Member

intech commented Dec 16, 2022

Judging by the CI error, dependency packages like graphql-subscriptions and possibly others should be updated so that there is no conflict between new and old packages in peer dependencies.

@intech intech self-assigned this Dec 20, 2022
@abdavid
Copy link

abdavid commented Mar 15, 2023

How is this coming along? Is there anything I can do to help?

@AndreMaz
Copy link
Member

How is this coming along? Is there anything I can do to help?

Fixing broken tests would help a lot
image

@AndreMaz AndreMaz changed the title Upgdate to latest Apollo server / subscriptions ( v3 ) Upgdate to latest Apollo server / subscriptions Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants