Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example config in README.md #398

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

cocoon
Copy link
Contributor

@cocoon cocoon commented Oct 4, 2024

is there missing ".com" in the example config?

docs tell to use .com:
https://developers.cloudflare.com/1.1.1.1/encryption/dns-over-https/make-api-requests/
https://cloudflare-dns.com/dns-query

without it it I receive errors:

WARN:smartdns::dns_client:601: lookup ip: cloudflare-dns failed, proto error: no records found for Query { name: Name("cloudflare-dns."), query_type: AAAA, query_class: IN }

for cloudflare there was missing .com
@mokeyish mokeyish merged commit 47b2fa0 into mokeyish:main Oct 4, 2024
19 checks passed
@mokeyish
Copy link
Owner

mokeyish commented Oct 4, 2024

@cocoon thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants