Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Ignore UdpSocket's WSAECONNRESET error on Windows #392

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mokeyish
Copy link
Owner

closes #391

@mokeyish
Copy link
Owner Author

@chmichael Hi, I have changed to using windows_rs based on the code you provided. But I'm not sure if that solves the problem, can you help verify it?

Download link:https://github.com/mokeyish/smartdns-rs/actions/runs/11051243572

@chmichael
Copy link

Compiled and running it with 0 udp errors on windows! It works! 😄
ps: i've used the version = "0.58" windows (there is 0.60 with many more fixes but not on cargo yet)

Thank you

@mokeyish
Copy link
Owner Author

@chmichael Does this error only occur in Windows MSVC? I see that Windows GNU has a compilation error, so Windows GNU does not apply this code.

https://github.com/mokeyish/smartdns-rs/actions/runs/11051683602/job/30702103661

@mokeyish mokeyish merged commit 1758fb7 into main Sep 26, 2024
32 checks passed
@mokeyish mokeyish deleted the win_udp_socket_err branch September 26, 2024 12:58
@chmichael
Copy link

chmichael commented Sep 26, 2024

@chmichael Does this error only occur in Windows MSVC? I see that Windows GNU has a compilation error, so Windows GNU does not apply this code.

https://github.com/mokeyish/smartdns-rs/actions/runs/11051683602/job/30702103661

@mokeyish
Well i'm using the official rust compiler from https://www.rust-lang.org/tools/install and no error occured on my end.
I've applied your last change in net.rs '''#[cfg(all(target_os = "windows", target_env = "msvc"))]''' and compiled fine.

εικόνα

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: WARN:smartdns::server::udp:36: error receiving message on udp_socket (and fix)
2 participants