API stabilization: Smaller core cache API, prefer shorter names for common methods #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cache policy
- Rename the following cache methods, and make the methods wih old
names deprecated:
- `get_or_insert_with` -> `get_with`
- `get_or_try_insert_with` -> `try_get_with`
- Add cache `Policy` and move the following cache methods to it:
- `max_capacity`
- `num_segments`
- `time_to_live`
- `time_to_idle`
Closed
- Add `blocking()` method to `future::Cache` returning `BlockingOp`.
- Move the following methods from `future::Cache` to `BlockingOp`:
- `blocking_insert()` -> `blocking().insert()`
- `blocking_invalidate()` -> `blocking().invalidate()`
Fix broken doc links between `future::Cache` and `future::BlockingOp`.
Fix broken links in the CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the following cache methods, and make the methods with old names deprecated:
get_or_insert_with(K, F)→get_with(K, F)get_or_try_insert_with(K, F)→try_get_with(K, F)Add
policy()method to caches returning a cachePolicystruct. Move the following cache methods to it:max_capacity()→policy().max_capacity()num_segments()→policy().num_segments()time_to_live()→policy().time_to_live()time_to_idle()→policy().time_to_idle()Add
blocking()method tofuture::Cachereturning aBlockingOpstruct. Move the following cache methods to it:blocking_insert(K, V)→blocking().insert(K, V)blocking_invalidate(K, V)→blocking().invalidate(K, V)