Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version file and use it for Rakefile, instead of parsing with regexp... #262

Merged
merged 1 commit into from
Jul 29, 2014

Conversation

davispuh
Copy link
Collaborator

Create version.rb file for version info, like typically gems do. Advantages are that doesn't have to include everything just to see current version, for example in gemspec. Also in Rakefile use this file, instead of manually parsing with regexp.

Also added dependency versions to gemspec to avoid warning (about how it's not recommended) when building gem.

@greysteil
Copy link
Contributor

What's the status of this? Looks like a bunch of other PRs are waiting for it.

@davispuh
Copy link
Collaborator Author

@leejarvis Looks like you're really busy? What about if I create new beta branch and merge PRs there and then when you've time you can review them all and merge in master. But in meanwhile I can manage that beta branch.

@leejarvis
Copy link
Collaborator

@davispuh sure that sounds fine. I think this PR is fine to merge to master also, so go ahead

davispuh added a commit that referenced this pull request Jul 29, 2014
Create version file and use it for Rakefile, instead of parsing with regexp...
@davispuh davispuh merged commit 1b93e33 into mojombo:master Jul 29, 2014
@davispuh
Copy link
Collaborator Author

Cool 😎

@davispuh davispuh deleted the version branch September 13, 2014 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants