-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #855: Set should evaluate expressions #856
Conversation
@slawekjaranowski please review |
@pzygielo @slachiewicz @slawekjaranowski do you think there might be other corner cases to check here? |
@ajarmoniuk thanks for asking, but I'm not advanced user of versions-m-p nor I know the codebase well. |
Sławek's question is valid though -- perhaps this PR is not needed after all. |
a Corner cases from https://maven.apache.org/maven-ci-friendly.html Property as:
version with multiple properties:
Multi Module example |
@slawekjaranowski added these corner cases |
versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/SetMojo.java
Outdated
Show resolved
Hide resolved
On more test will be appreciable: Parent with property:
|
Assuming you meant a parent with a property with a child module -- added. |
Fixing a regression after #799
The premise of that PR was that the mojo was updating every file if it did not find any match anywhere. This made the mojo update files where e.g. the version was specified as a parameter.
The fix does it differently -- by resolving parameters and checking if they match the artifact coordinates.