Resolves #807: Abstracting a common base for UseLatestVersionsMojo and UseLatestReleasesMojo #808
+308
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Abstracting a common base for UseLatestVersionsMojo and UseLatestReleasesMojo. - Elaborating on the difference between a "release" and a "version"
|
@slawekjaranowski please review |
This was
linked to
issues
Nov 4, 2022
|
My own afterthought after this is merged is that, as with other mojos. Across the whole plugin we basically have a host of different features, which may be turned on and off. I think I'll need to review the whole of the plugin and use a pattern like the decorator so that we can simply compose the behaviour of the mojo of different behaviours, depending on which features are enabled. See #289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues:
#807
#516